launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:py3-TestLaunchpadCookieClientIdManager into launchpad:master.

Commit message:
Adjust TestLaunchpadCookieClientIdManager for Python 3

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/398526

Unlike Python 2's cookielib, Python 3's http.cookies prefers to spell "httponly" as "HttpOnly".
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:py3-TestLaunchpadCookieClientIdManager into launchpad:master.

diff --git a/lib/lp/services/webapp/tests/test_session.py b/lib/lp/services/webapp/tests/test_session.py
index b99ff4f..84e94cd 100644
--- a/lib/lp/services/webapp/tests/test_session.py
+++ b/lib/lp/services/webapp/tests/test_session.py
@@ -67,7 +67,7 @@ class TestLaunchpadCookieClientIdManager(TestCase):
         request = LaunchpadTestRequest()
         LaunchpadCookieClientIdManager().setRequestId(request, 'some-id')
         self.assertThat(
-            dict(request.response.getHeaders())['Set-Cookie'],
+            dict(request.response.getHeaders())['Set-Cookie'].lower(),
             Contains('; httponly;'))
 
     def test_stable_client_id(self):