launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:py3-test-zcmldirectives into launchpad:master.

Commit message:
Port zcmldirectives.txt to Python 3

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/398529

It doesn't seem necessary any more to use a classic class, and those no longer exist on Python 3.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:py3-test-zcmldirectives into launchpad:master.

diff --git a/lib/lp/services/webapp/doc/zcmldirectives.txt b/lib/lp/services/webapp/doc/zcmldirectives.txt
index e70ceed..c5c0b84 100644
--- a/lib/lp/services/webapp/doc/zcmldirectives.txt
+++ b/lib/lp/services/webapp/doc/zcmldirectives.txt
@@ -57,11 +57,7 @@ default view for the IFooLayer layer.
     ...     pass
     >>> request = Request()
 
-    >>> import types
     >>> class FooView:
-    ...     """classic class that is used for a view on an IFoo"""
-    ...     __metaclass__ = types.ClassType
-    ...
     ...     def __call__(self):
     ...         return "FooView was called"
     >>> lp.testing.FooView = FooView