launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:py3-test-offsite-form-post into launchpad:master.

Commit message:
Fix hash-seed-dependent failure in xx-offsite-form-post.txt

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/398632

The last test in xx-offsite-form-post.txt might raise an exception with "None isn't acceptable as a value for Product.owner" or "None isn't acceptable as a value for Product.registrant" depending on the hash seed.  Either one demonstrates the desired behaviour just as well, so relax the test slightly.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:py3-test-offsite-form-post into launchpad:master.

diff --git a/lib/lp/app/stories/basics/xx-offsite-form-post.txt b/lib/lp/app/stories/basics/xx-offsite-form-post.txt
index 045c34a..774b5d6 100644
--- a/lib/lp/app/stories/basics/xx-offsite-form-post.txt
+++ b/lib/lp/app/stories/basics/xx-offsite-form-post.txt
@@ -209,7 +209,7 @@ processed despite the bogus referrer, but...
   ... # doctest: +IGNORE_EXCEPTION_MODULE_IN_PYTHON2
   Traceback (most recent call last):
   ...
-  storm.exceptions.NoneError: None isn't acceptable as a value for Product.owner
+  storm.exceptions.NoneError: None isn't acceptable as a value for Product...
 
 You're making an _anonymous_ request. That's a request that 1) is not
 associated with any Launchpad user account (thus the NoneError when