launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] ~pappacena/launchpad:oci-recipe-cascade-delete-bugfix into launchpad:master

To: "Thiago F. Pappacena" <pappacena@xxxxxxxxx>
From: Colin Watson <cjwatson@xxxxxxxxxxxxx>
Date: Thu, 25 Feb 2021 15:03:20 -0000
In-reply-to: <161426534000.31305.1732170830434798277.launchpad@ackee.canonical.com>
Reply-to: mp+398711@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

LGTM, though could you adjust the commit message to use the form mentioned in https://help.launchpad.net/Code/Git#Linking_to_bugs since that's what I tend to search for when preparing deployments?  I.e. "LP: #1916605" somewhere.
-- 
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/398711
Your team Launchpad code reviewers is subscribed to branch ~pappacena/launchpad:oci-recipe-cascade-delete-bugfix.

References

[Merge] ~pappacena/launchpad:oci-recipe-cascade-delete-bugfix into launchpad:master
From: Thiago F. Pappacena, 2021-02-25