← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] ~pappacena/launchpad:better-error-msg-snap-without-source into launchpad:master

 


Diff comments:

> diff --git a/lib/lp/snappy/model/snap.py b/lib/lp/snappy/model/snap.py
> index 7e3d14c..2511625 100644
> --- a/lib/lp/snappy/model/snap.py
> +++ b/lib/lp/snappy/model/snap.py
> @@ -1359,6 +1359,9 @@ class SnapSet:
>          """See `ISnapSet`."""
>          if ISnap.providedBy(context):
>              context = context.source
> +        if context is None:
> +            raise CannotFetchSnapcraftYaml(
> +                "Snap source is not defined", unsupported_remote=True)

Thanks! Fixing and landing this MP.

>          try:
>              paths = (
>                  "snap/snapcraft.yaml",


-- 
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/398726
Your team Launchpad code reviewers is subscribed to branch ~pappacena/launchpad:better-error-msg-snap-without-source.


References