launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:py3-test-checkForNewBuilders into launchpad:master.

Commit message:
Fix test_checkForNewBuilders for Python 3

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/398980

New builder names aren't returned in any particular order, so we need to use `assertContentEqual` rather than just `assertEqual`.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:py3-test-checkForNewBuilders into launchpad:master.

diff --git a/lib/lp/buildmaster/tests/test_manager.py b/lib/lp/buildmaster/tests/test_manager.py
index 6b8c8d5..4dc6b47 100644
--- a/lib/lp/buildmaster/tests/test_manager.py
+++ b/lib/lp/buildmaster/tests/test_manager.py
@@ -1430,7 +1430,7 @@ class TestNewBuilders(TestCase):
         factory = LaunchpadObjectFactory()
         for builder_name in new_builders:
             factory.makeBuilder(name=builder_name)
-        self.assertEqual(new_builders, manager.checkForNewBuilders())
+        self.assertContentEqual(new_builders, manager.checkForNewBuilders())
 
     def test_checkForNewBuilders_detects_builder_only_once(self):
         # checkForNewBuilders() only detects a new builder once.