launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:py3-test-bugnotification-sending into launchpad:master.

Commit message:
bugnotification-sending.txt: Handle minor differences in flattened email

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/399071

It's reasonable for `SendBugNotifications.main` to use `message.as_string()`, since it's just for debugging output; but quoted-printable encoding of whitespace at the end of a line is handled slightly differently in Python 3.  Ignore this discrepancy.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:py3-test-bugnotification-sending into launchpad:master.

diff --git a/lib/lp/bugs/doc/bugnotification-sending.txt b/lib/lp/bugs/doc/bugnotification-sending.txt
index 714db22..8d947fb 100644
--- a/lib/lp/bugs/doc/bugnotification-sending.txt
+++ b/lib/lp/bugs/doc/bugnotification-sending.txt
@@ -586,11 +586,11 @@ makes it write out the emails it sends.
     another comment.
     <BLANKLINE>
     ** Summary changed:
+    <BLANKLINE>
     - Summary #431
     + Summary bleugh I'm going mad
     <BLANKLINE>
-    -- =
-    <BLANKLINE>
+    --...
     You received this bug notification because...
     INFO    Notifying mark@xxxxxxxxxxx about bug 1.
     ...