launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #26548
[Merge] ~cjwatson/launchpad:py3-loggerhead-secure-cookie into launchpad:master
The proposal to merge ~cjwatson/launchpad:py3-loggerhead-secure-cookie into launchpad:master has been updated.
Description changed to:
paste.auth.cookie is deprecated, and getting it to work with Python 3 is cumbersome at best. Switch to secure-cookie, which seems to have a nicer API for our purposes, appears to be better-maintained (by the Werkzeug folks), and allows us to fix a long-standing minor deficiency around deleting session cookies on logout.
This will break existing Loggerhead sessions. I think that's OK since it's a one-time thing, but it's worth noting.
Dependencies MP: https://code.launchpad.net/~cjwatson/lp-source-dependencies/+git/lp-source-dependencies/+merge/399126
For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/399127
--
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:py3-loggerhead-secure-cookie into launchpad:master.
References