launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:py3-sourcepackage-index-binaries into launchpad:master.

Commit message:
Sort binaries on SourcePackage:+index

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/399191

Tests sometimes fail on Python 3 otherwise.  It's probably most natural to sort the binaries lexicographically by name.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:py3-sourcepackage-index-binaries into launchpad:master.

diff --git a/lib/lp/registry/templates/sourcepackage-index.pt b/lib/lp/registry/templates/sourcepackage-index.pt
index d91e265..df85b88 100644
--- a/lib/lp/registry/templates/sourcepackage-index.pt
+++ b/lib/lp/registry/templates/sourcepackage-index.pt
@@ -86,7 +86,7 @@
 
             <div id="binaries" tal:define="binaries view/binaries">
               <ul tal:condition="binaries">
-                <li tal:repeat="bin_name binaries">
+                <li tal:repeat="bin_name python:sorted(binaries)">
                   <span tal:replace="bin_name" />
                   <span tal:repeat="archtag python:binaries[bin_name]">
                     (<a tal:content="archtag" tal:attributes="href