launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/lpbuildbot-worker:create-make-clean into lpbuildbot-worker:main.

Commit message:
create-lp-tests-lxd: Run "make clean" before "make"

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/lpbuildbot-worker/+git/lpbuildbot-worker/+merge/399291

Otherwise we may run into trouble if the tree wasn't clean and was (for example) built for a different Python version.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/lpbuildbot-worker:create-make-clean into lpbuildbot-worker:main.

diff --git a/create-lp-tests-lxd b/create-lp-tests-lxd
index e821bc2..8a5822a 100755
--- a/create-lp-tests-lxd
+++ b/create-lp-tests-lxd
@@ -231,6 +231,9 @@ def install_code(container, series, directory):
     )
 
     print("Building launchpad")
+    _exec(
+        container, ["make", "clean"], user="buildbot", cwd="{}/devel".format(directory)
+    )
     _exec(container, ["make"], user="buildbot", cwd="{}/devel".format(directory))
     print("Make install for launchpad")
     _exec(container, ["make", "install"], cwd="{}/devel".format(directory))