launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:db-bugsubscriptionfilter-structuralsubscription-not-null into launchpad:db-devel.

Commit message:
Make BugSubscriptionFilter.structuralsubscription NOT NULL

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers): db

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/399430

The model requires this, but issues in the test suite made it impossible to constrain this properly in the database until recently.

See https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/397103 and https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/397168.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:db-bugsubscriptionfilter-structuralsubscription-not-null into launchpad:db-devel.

diff --git a/database/schema/patch-2210-27-0.sql b/database/schema/patch-2210-27-0.sql
new file mode 100644
index 0000000..7a8b01a
--- /dev/null
+++ b/database/schema/patch-2210-27-0.sql
@@ -0,0 +1,9 @@
+-- Copyright 2021 Canonical Ltd.  This software is licensed under the
+-- GNU Affero General Public License version 3 (see the file LICENSE).
+
+SET client_min_messages=ERROR;
+
+ALTER TABLE BugSubscriptionFilter
+    ALTER COLUMN structuralsubscription SET NOT NULL;
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2210, 27, 0);