launchpad-reviewers team mailing list archive

[Barry Price <barry.price@xxxxxxxxxxxxx>]

Barry Price has proposed merging ~barryprice/turnip:master into turnip:master.

Commit message:
Add a hint to Git E2E checks - the root cause of failures here is often the NFS service

https://portal.admin.canonical.com/C126848

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~barryprice/turnip/+git/turnip/+merge/399496
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~barryprice/turnip:master into turnip:master.

diff --git a/charm/layer/turnip-base/lib/charms/turnip/base.py b/charm/layer/turnip-base/lib/charms/turnip/base.py
index bc2dda3..19184f0 100644
--- a/charm/layer/turnip-base/lib/charms/turnip/base.py
+++ b/charm/layer/turnip-base/lib/charms/turnip/base.py
@@ -320,7 +320,7 @@ def add_nagios_e2e_checks(nagios):
         nagios.add_check(
             [os.path.join(nrpe_dir(), 'check_git_refs'), url],
             name='check_turnip_git_refs_{}'.format(i),
-            description='Git E2E {}'.format(url),
+            description='Git E2E {} (hint: check nfs-ganesha status)'.format(url),
             context=config['nagios_context'])