launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/lpbuildbot/reduce-timeout-more into lp:lpbuildbot.

Commit message:
Reduce test timeouts some more.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/lpbuildbot/reduce-timeout-more/+merge/399584

The "timeout" parameter actually refers to a time after which the command will be killed if it fails to produce any output (see https://docs.buildbot.net/0.8.5/manual/cfg-buildsteps.html#step-ShellCommand), so we can make this considerably stricter; 15 minutes seems reasonable.  "maxTime" is what I previously thought "timeout" meant, so set that to three hours.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/lpbuildbot/reduce-timeout-more into lp:lpbuildbot.

=== modified file 'master.cfg'
--- master.cfg	2021-03-01 18:04:15 +0000
+++ master.cfg	2021-03-12 13:53:36 +0000
@@ -146,7 +146,8 @@
     addEnvironmentPrepSteps(f, tree, container, variables=variables)
     f.addStep(
         lpbuildbot.test.Test(
-            timeout=2*60*60,
+            timeout=15*60,
+            maxTime=3*60*60,
             env={
                 'TEMP': "{}/devel/temp".format(tree),
                 'LP_LXD_CONTAINER': container,