launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Review: Approve



Diff comments:

> diff --git a/lib/lp/archivepublisher/scripts/copy_signingkeys.py b/lib/lp/archivepublisher/scripts/copy_signingkeys.py
> index e4a46bd..acd159f 100644
> --- a/lib/lp/archivepublisher/scripts/copy_signingkeys.py
> +++ b/lib/lp/archivepublisher/scripts/copy_signingkeys.py
> @@ -42,6 +42,10 @@ class CopySigningKeysScript(LaunchpadScript):
>              "-n", "--dry-run", action="store_true", default=False,
>              help="Report what would be done, but don't actually copy keys.")
>  
> +        self.parser.add_option(
> +            "-o", "--overwrite", action="store_true", default=False,

I think we can omit the short version of the option.  This should be fairly rare, and it's potentially dangerous enough that we want people to have to spell it out, IMO.

> +            help="Overwrite existing keys when executing the copy.")
> +
>      def getArchive(self, reference):
>          archive = getUtility(IArchiveSet).getByReference(reference)
>          if archive is None:


-- 
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/400277
Your team Launchpad code reviewers is subscribed to branch ~pappacena/launchpad:copy-signing-key-overwrite.