launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Review: Approve



Diff comments:

> diff --git a/lib/lp/registry/templates/pillar-sharing-details.pt b/lib/lp/registry/templates/pillar-sharing-details.pt
> index a6f2710..dc907dd 100644
> --- a/lib/lp/registry/templates/pillar-sharing-details.pt
> +++ b/lib/lp/registry/templates/pillar-sharing-details.pt
> @@ -30,6 +30,7 @@
>        <tal:bugs replace="view/shared_bugs_count">0</tal:bugs> bugs,
>        <tal:branches replace="view/shared_branches_count">0</tal:branches> Bazaar branches,
>        <tal:gitrepositories replace="view/shared_gitrepositories_count">0</tal:gitrepositories> Git repositories,
> +      <tal:snaps replace="view/shared_snaps_count">0</tal:snaps> snaps,

Maybe "snap recipes", since we're generally trying to follow that form in new user-facing text?

>        and  <tal:specifications
>        replace="view/shared_specifications_count">0</tal:specifications>
>        blueprints shared with <tal:name replace="view/person/displayname">


-- 
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/400607
Your team Launchpad code reviewers is subscribed to branch ~pappacena/launchpad:fix-pillar-person-oops.