launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Review: Approve



Diff comments:

> diff --git a/lib/lp/code/browser/gitrepository.py b/lib/lp/code/browser/gitrepository.py
> index 76606cd..c41cafe 100644
> --- a/lib/lp/code/browser/gitrepository.py
> +++ b/lib/lp/code/browser/gitrepository.py
> @@ -1420,8 +1418,6 @@ class GitRepositoryDeletionView(LaunchpadFormView):
>  
>      @property
>      def warning_message(self):
> -        if self.context.status == GitRepositoryStatus.CREATING:
> -            return "This repository is being created and cannot be deleted."
>          return None

Can we remove this property entirely from this view and the associated template, now that it's always None?

>  
>  


-- 
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/400490
Your team Launchpad code reviewers is subscribed to branch ~pappacena/launchpad:allow-delete-gitrepo-while-creating.