launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/lp-codeimport:charm-log-archives-directory into lp-codeimport:master.

Commit message:
Create log archives directory

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/lp-codeimport/+git/lp-codeimport/+merge/401104

There's no real point checking for the archives directory and bailing out if we don't find it, when we would just `mkdir -p` it a few lines later anyway.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/lp-codeimport:charm-log-archives-directory into lp-codeimport:master.

diff --git a/charm/lp-codeimport/templates/clean_importd_logs.sh.j2 b/charm/lp-codeimport/templates/clean_importd_logs.sh.j2
index 59a4708..613e674 100644
--- a/charm/lp-codeimport/templates/clean_importd_logs.sh.j2
+++ b/charm/lp-codeimport/templates/clean_importd_logs.sh.j2
@@ -17,12 +17,6 @@ DEST_ROOT='{{ logs_dir }}'
 DEST_ARCH="$DEST_ROOT/archives"
 
 
-# Check for Archive directory, barf loudly if not found!
-if [ ! -d "$DEST_ARCH" ]; then
-    echo "ERROR! Archive path does NOT exist. $DEST_ARCH"
-    exit 1
-fi
-
 DEST="$DEST_ARCH"/$(date +%F)
 
 if ! mkdir -p "$DEST"; then