launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Diff comments:

> diff --git a/lib/lp/registry/interfaces/ociproject.py b/lib/lp/registry/interfaces/ociproject.py
> index 85fb588..d2cabc8 100644
> --- a/lib/lp/registry/interfaces/ociproject.py
> +++ b/lib/lp/registry/interfaces/ociproject.py
> @@ -67,7 +72,9 @@ from lp.services.fields import (
>  OCI_PROJECT_ALLOW_CREATE = 'oci.project.create.enabled'
>  
>  
> -class IOCIProjectView(IHasGitRepositories, Interface):
> +class IOCIProjectView(IHasGitRepositories, IServiceUsage,

DistributionSourcePackages have their own Overview, Code, Bugs, Translations, and Answers pages (see e.g. https://launchpad.net/ubuntu/+source/base-files), and OCIProjects were intended to be analogous to DistributionSourcePackages in this sort of respect.

> +                      IHasOfficialBugTags, IStructuralSubscriptionTarget,
> +                      Interface):
>      """IOCIProject attributes that require launchpad.View permission."""
>  
>      id = Int(title=_("ID"), required=True, readonly=True)


-- 
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/394181
Your team Launchpad code reviewers is subscribed to branch ~pappacena/launchpad:bugtask-oci-project.