launchpad-reviewers team mailing list archive

[Cristian Gonzalez <cristian.gonzalez@xxxxxxxxxxxxx>]

Diff comments:

> diff --git a/lib/lp/registry/tests/test_distribution.py b/lib/lp/registry/tests/test_distribution.py
> index 0b9f712..44defc1 100644
> --- a/lib/lp/registry/tests/test_distribution.py
> +++ b/lib/lp/registry/tests/test_distribution.py
> @@ -842,3 +843,83 @@ class TestDistributionWebservice(TestCaseWithFactory):
>              start_date=(now - day).isoformat(),
>              end_date=now.isoformat())
>          self.assertEqual([], empty_response.jsonBody())
> +
> +    def test_setOCICredentials(self):

Even though the rest parameters that the setOCICredentials method receives are not required, I guess it will make sense to check that those are set properly here.

> +        # We can add OCI Credentials to the distribution
> +        self.setConfig()
> +        with person_logged_in(self.person):
> +            distro = self.factory.makeDistribution(owner=self.person)
> +            distro.oci_project_admin = self.person
> +            distro_url = api_url(distro)
> +
> +        resp = self.webservice.named_post(
> +            distro_url,
> +            "setOCICredentials",
> +            registry_url="http://registry.test";,
> +        )
> +
> +        self.assertEqual(200, resp.status)
> +        with person_logged_in(self.person):
> +            self.assertEqual(
> +                "http://registry.test";,
> +                distro.oci_registry_credentials.url
> +            )
> +
> +    def test_setOCICredentials_no_oci_admin(self):
> +        # If there's no oci_project_admin to own the credentials, error
> +        self.setConfig()
> +        with person_logged_in(self.person):
> +            distro = self.factory.makeDistribution(owner=self.person)
> +            distro_url = api_url(distro)
> +
> +        resp = self.webservice.named_post(
> +            distro_url,
> +            "setOCICredentials",
> +            registry_url="http://registry.test";,
> +        )
> +
> +        self.assertEqual(400, resp.status)
> +        self.assertIn(
> +            b"no OCI Project Admin for this distribution",
> +            resp.body)
> +
> +    def test_setOCICredentials_changes_credentials(self):
> +        # if we have existing credentials, we should change them
> +        self.setConfig()
> +        with person_logged_in(self.person):
> +            distro = self.factory.makeDistribution(owner=self.person)
> +            distro.oci_project_admin = self.person
> +            credentials = self.factory.makeOCIRegistryCredentials()
> +            distro.oci_registry_credentials = credentials
> +            distro_url = api_url(distro)
> +
> +        resp = self.webservice.named_post(
> +            distro_url,
> +            "setOCICredentials",
> +            registry_url="http://registry.test";,
> +        )
> +
> +        self.assertEqual(200, resp.status)
> +        with person_logged_in(self.person):
> +            self.assertEqual(
> +                "http://registry.test";,
> +                distro.oci_registry_credentials.url
> +            )
> +
> +    def test_deleteOCICredentials(self):
> +        # We can remove existing credentials
> +        self.setConfig()
> +        with person_logged_in(self.person):
> +            distro = self.factory.makeDistribution(owner=self.person)
> +            distro.oci_project_admin = self.person
> +            credentials = self.factory.makeOCIRegistryCredentials()
> +            distro.oci_registry_credentials = credentials
> +            distro_url = api_url(distro)
> +
> +        resp = self.webservice.named_post(
> +            distro_url,
> +            "deleteOCICredentials")
> +
> +        self.assertEqual(200, resp.status)
> +        with person_logged_in(self.person):
> +            self.assertIsNone(distro.oci_registry_credentials)


-- 
https://code.launchpad.net/~twom/launchpad/+git/launchpad/+merge/402084
Your team Launchpad code reviewers is requested to review the proposed merge of ~twom/launchpad:oci-set-distribution-credentials-via-api into launchpad:master.