launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:py3-env-var into launchpad:master.

Commit message:
Makefile: Accept PYTHON environment variable

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/402438

This is normally a bad idea, because the environment is easily polluted by accident.  However, in this case the risk seems relatively low, and it's the easiest way to get production appservers to use the desired version via the current maze of deployment-manager configuration and init scripts.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:py3-env-var into launchpad:master.

diff --git a/Makefile b/Makefile
index 0c824f8..17df062 100644
--- a/Makefile
+++ b/Makefile
@@ -8,7 +8,7 @@
 # Borrowed from dpkg.
 lazy_eval ?= $(or $(value CACHE_$(1)),$(eval CACHE_$(1) := $(shell $(2)))$(value CACHE_$(1)))
 
-PYTHON:=python2.7
+PYTHON?=python2.7
 
 WD:=$(shell pwd)
 PY=$(WD)/bin/py