launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #27113
Re: [Merge] ~pappacena/launchpad:prevent-admins-from-editing-codereview-comment into launchpad:master
Pushed the permission name change
Diff comments:
> diff --git a/lib/lp/code/configure.zcml b/lib/lp/code/configure.zcml
> index a373286..7a019ed 100644
> --- a/lib/lp/code/configure.zcml
> +++ b/lib/lp/code/configure.zcml
> @@ -548,7 +548,7 @@
> <!-- CodeReviewComment -->
>
> <class class="lp.code.model.codereviewcomment.CodeReviewComment">
> - <require permission="launchpad.Edit"
> + <require permission="launchpad.Driver"
Sure!
> interface="lp.services.messages.interfaces.message.IMessageEdit" />
> <allow interface="lp.code.interfaces.codereviewcomment.ICodeReviewCommentView"/>
> <allow interface="lp.code.interfaces.branchtarget.IHasBranchTarget"/>
--
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/403146
Your team Launchpad code reviewers is subscribed to branch ~pappacena/launchpad:prevent-admins-from-editing-codereview-comment.
References