launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #27201
[Merge] ~cjwatson/lp-codeimport:charm-no-basenode into lp-codeimport:master
Colin Watson has proposed merging ~cjwatson/lp-codeimport:charm-no-basenode into lp-codeimport:master.
Commit message:
charm: Remove mention of basenode
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~cjwatson/lp-codeimport/+git/lp-codeimport/+merge/404016
basenode is deprecated, and the nrpe subordinate seems to sort out rsyncd.conf for us nowadays.
--
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/lp-codeimport:charm-no-basenode into lp-codeimport:master.
diff --git a/charm/lp-codeimport/config.yaml b/charm/lp-codeimport/config.yaml
index 4a1489a..4b2e62d 100644
--- a/charm/lp-codeimport/config.yaml
+++ b/charm/lp-codeimport/config.yaml
@@ -77,4 +77,4 @@ options:
default: ""
description: >
Hosts that should be allowed to rsync logs. Note that this relies on
- basenode.
+ the nrpe subordinate charm to set up /etc/rsyncd.conf properly.