launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/turnip:disable-auto-gc into turnip:master.

Commit message:
Disable receive.autogc

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/turnip/+git/turnip/+merge/404566

We have automatic repack jobs now, so it probably makes more sense to rely on those even if they're somewhat delayed rather than doing the garbage-collection in-band.  At the moment we often see significant delays at the end of a push which look like the result of "git receive-pack" running "git gc --auto".
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/turnip:disable-auto-gc into turnip:master.

diff --git a/git.config.yaml b/git.config.yaml
index 13c4ccd..3baed85 100644
--- a/git.config.yaml
+++ b/git.config.yaml
@@ -5,4 +5,5 @@ core.logallrefupdates: True
 pack.depth: 100
 pack.window: 100
 pack.windowMemory: 2g
+receive.autogc: False
 repack.writeBitmaps: True
diff --git a/turnip/pack/tests/test_helpers.py b/turnip/pack/tests/test_helpers.py
index f29cd74..0e8cc82 100644
--- a/turnip/pack/tests/test_helpers.py
+++ b/turnip/pack/tests/test_helpers.py
@@ -244,8 +244,9 @@ class TestEnsureConfig(TestCase):
     def assertWritesCorrectConfig(self):
         helpers.ensure_config(self.repo_dir)
         config = Config(path=self.config_path)
-        self.assertTrue(config['core.logallrefupdates'])
-        self.assertTrue(config['repack.writeBitmaps'])
+        self.assertEqual('true', config['core.logallrefupdates'])
+        self.assertEqual('true', config['repack.writeBitmaps'])
+        self.assertEqual('false', config['receive.autogc'])
 
     def test_writes_new(self):
         self.assertWritesCorrectConfig()