launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:flake8-f901 into launchpad:master.

Commit message:
flake8: Fix F901 NotImplemented/NotImplementedError confusion

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/406629

`NotImplemented` is a singleton object used by some arithmetic and rich comparison methods.  `NotImplementedError` is an exception type.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:flake8-f901 into launchpad:master.

diff --git a/lib/lp/app/browser/vocabulary.py b/lib/lp/app/browser/vocabulary.py
index 40f75e7..e107cb1 100644
--- a/lib/lp/app/browser/vocabulary.py
+++ b/lib/lp/app/browser/vocabulary.py
@@ -229,11 +229,11 @@ class TargetPickerEntrySourceAdapter(DefaultPickerEntrySourceAdapter):
 
     def getDescription(self, target):
         """Gets the description data for target picker entries."""
-        raise NotImplemented
+        raise NotImplementedError
 
     def getMaintainer(self, target):
         """Gets the maintainer information for the target picker entry."""
-        raise NotImplemented
+        raise NotImplementedError
 
     def getCommercialSubscription(self, target):
         """Gets the commercial subscription details for the target."""
diff --git a/lib/lp/buildmaster/tests/test_buildfarmjobbehaviour.py b/lib/lp/buildmaster/tests/test_buildfarmjobbehaviour.py
index 8b80346..2c6106e 100644
--- a/lib/lp/buildmaster/tests/test_buildfarmjobbehaviour.py
+++ b/lib/lp/buildmaster/tests/test_buildfarmjobbehaviour.py
@@ -287,7 +287,7 @@ class TestGetUploadMethodsMixin:
 
     def makeBuild(self):
         """Allow classes to override the build with which the test runs."""
-        raise NotImplemented
+        raise NotImplementedError
 
     def setUp(self):
         super(TestGetUploadMethodsMixin, self).setUp()