launchpad-reviewers team mailing list archive

[Ioana Lasc <ioana.lasc@xxxxxxxxxxxxx>]

Ioana Lasc has proposed merging ~ilasc/launchpad:flake8-e721 into launchpad:master.

Commit message:
flake8: fix E721 do not compare types

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~ilasc/launchpad/+git/launchpad/+merge/406634
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~ilasc/launchpad:flake8-e721 into launchpad:master.

diff --git a/lib/lp/services/profile/mem.py b/lib/lp/services/profile/mem.py
index 788d1fa..cf3fdf7 100644
--- a/lib/lp/services/profile/mem.py
+++ b/lib/lp/services/profile/mem.py
@@ -145,7 +145,7 @@ def countsByType(objects, n=30):
     """
     d = {}
     for obj in objects:
-        if type(obj) is types.InstanceType:
+        if isinstance(obj, types.InstanceType):
             cls = obj.__class__
         else:
             cls = type(obj)