launchpad-reviewers team mailing list archive

[Ioana Lasc <ioana.lasc@xxxxxxxxxxxxx>]

Ioana Lasc has proposed merging ~ilasc/launchpad:flake8-f601 into launchpad:master.

Commit message:
flake8: fix F601

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~ilasc/launchpad/+git/launchpad/+merge/406642
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~ilasc/launchpad:flake8-f601 into launchpad:master.

diff --git a/lib/lp/bugs/tests/test_bugchanges.py b/lib/lp/bugs/tests/test_bugchanges.py
index bd13985..8ba4d80 100644
--- a/lib/lp/bugs/tests/test_bugchanges.py
+++ b/lib/lp/bugs/tests/test_bugchanges.py
@@ -1451,12 +1451,12 @@ class TestBugChanges(TestCaseWithFactory):
         self.assertFalse(nomination.isApproved())
         self.saveOldChanges()
         nomination.approve(product.owner)
-
+        new_value = series.bugtargetname
         expected_activity = {
             'person': product.owner,
-            'newvalue': series.bugtargetname,
+            'newvalue': new_value,
             'whatchanged': 'bug task added',
-            'newvalue': series.bugtargetname,
+            'newvalue': new_value,
             }
 
         task_added_notification = {
@@ -1465,7 +1465,7 @@ class TestBugChanges(TestCaseWithFactory):
                 '** Also affects: %s\n'
                 '   Importance: Undecided\n'
                 '       Status: New' % (
-                    series.bugtargetname)),
+                    new_value)),
             'recipients': self.bug.getBugNotificationRecipients(
                 level=BugNotificationLevel.LIFECYCLE),
             }