launchpad-reviewers team mailing list archive

[Tom Wardill <tom.wardill@xxxxxxxxxxxxx>]

Tom Wardill has proposed merging ~twom/launchpad:lint-e632 into launchpad:master.

Commit message:
Remove F632 violations

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~twom/launchpad/+git/launchpad/+merge/406645
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~twom/launchpad:lint-e632 into launchpad:master.

diff --git a/lib/lp/blueprints/mail/notifications.py b/lib/lp/blueprints/mail/notifications.py
index f651520..be0b573 100644
--- a/lib/lp/blueprints/mail/notifications.py
+++ b/lib/lp/blueprints/mail/notifications.py
@@ -84,7 +84,7 @@ def notify_specification_modified(spec, event):
         if info_lines:
             info_lines.append('')
         workitems_delta = spec_delta.workitems_text
-        if workitems_delta['old'] is '':
+        if workitems_delta['old'] == '':
             info_lines.append('Work items set to:')
             info_lines.append(mail_wrapper.format(workitems_delta['new']))
         else:
diff --git a/lib/lp/soyuz/browser/packagerelationship.py b/lib/lp/soyuz/browser/packagerelationship.py
index a73a0db..e1d4034 100644
--- a/lib/lp/soyuz/browser/packagerelationship.py
+++ b/lib/lp/soyuz/browser/packagerelationship.py
@@ -83,7 +83,7 @@ class PackageRelationshipSet:
 
     def has_items(self):
         """See IPackageRelationshipSet."""
-        return len(self.contents) is not 0
+        return len(self.contents) != 0
 
     def __iter__(self):
         return iter(sorted(
diff --git a/lib/lp/soyuz/scripts/tests/test_initialize_distroseries.py b/lib/lp/soyuz/scripts/tests/test_initialize_distroseries.py
index e86a857..2920c84 100644
--- a/lib/lp/soyuz/scripts/tests/test_initialize_distroseries.py
+++ b/lib/lp/soyuz/scripts/tests/test_initialize_distroseries.py
@@ -115,7 +115,7 @@ class InitializationHelperTestCase(TestCaseWithFactory):
                 distroseries=parent,
                 pocket=pocket, status=PackagePublishingStatus.PUBLISHED)
             status = BuildStatus.FULLYBUILT
-            if package is 'chromium':
+            if package == 'chromium':
                 status = BuildStatus.FAILEDTOBUILD
             bpn = self.factory.getOrMakeBinaryPackageName(package)
             build = self.factory.makeBinaryPackageBuild(
@@ -125,7 +125,7 @@ class InitializationHelperTestCase(TestCaseWithFactory):
             bpr = self.factory.makeBinaryPackageRelease(
                 binarypackagename=bpn, build=build,
                 version=packages[package])
-            if package is not 'chromium':
+            if package != 'chromium':
                 self.factory.makeBinaryPackagePublishingHistory(
                     binarypackagerelease=bpr,
                     distroarchseries=parent_das,