launchpad-reviewers team mailing list archive

[Colin Watson <mp+406780@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:isort-no-gitignore into launchpad:master.

Commit message:
isort: Drop skip_gitignore

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/406780

This slows things down considerably since `isort` ends up walking the whole tree even with `--filter-files`, and it isn't useful when running as a `pre-commit` hook since `pre-commit` explicitly tells it which files to operate on.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:isort-no-gitignore into launchpad:master.

diff --git a/setup.cfg b/setup.cfg
index 149b9e9..77c02df 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -72,4 +72,3 @@ lines_after_imports = 2
 multi_line_output = 8
 order_by_type = false
 sections = FUTURE,PYTHONPATH,STDLIB,THIRDPARTY,FIRSTPARTY,LOCALFOLDER
-skip_gitignore = true