launchpad-reviewers team mailing list archive

[Ioana Lasc <mp+406996@xxxxxxxxxxxxxxxxxx>]

Ioana Lasc has proposed merging ~ilasc/launchpad:eslint-fix-no-console into launchpad:master.

Commit message:
Allow console log in lp-links.js

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~ilasc/launchpad/+git/launchpad/+merge/406996

In this particular we will want to allow that console.log call so I added a disable of no-console only for the next line.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~ilasc/launchpad:eslint-fix-no-console into launchpad:master.

diff --git a/lib/lp/app/javascript/lp-links.js b/lib/lp/app/javascript/lp-links.js
index 60b49de..eb4740e 100644
--- a/lib/lp/app/javascript/lp-links.js
+++ b/lib/lp/app/javascript/lp-links.js
@@ -80,6 +80,7 @@ YUI.add('lp.app.links', function(Y) {
                 failure: function(id, response, args) {
                     // If we have firebug installed, log the error.
                     if( Y.Lang.isValue(console) ) {
+                        // eslint-disable-next-line no-console
                         console.log("Link Check Error: " + args + ': '
                             + response.status + ' - ' +
                             response.statusText + ' - '