launchpad-reviewers team mailing list archive

[Colin Watson <mp+406999@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:eslint-tour into launchpad:master.

Commit message:
eslint: Fix errors in launchpad-tour.js

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/406999

Mostly trivial reformatting, but I also rearranged the `setTimeout` call to use a function.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:eslint-tour into launchpad:master.

diff --git a/lib/lp/app/tour/launchpad-tour.js b/lib/lp/app/tour/launchpad-tour.js
index 9f1693e..7199a0f 100644
--- a/lib/lp/app/tour/launchpad-tour.js
+++ b/lib/lp/app/tour/launchpad-tour.js
@@ -1,28 +1,30 @@
-// JavaScript Document
-
-var dropDownTimeOut = 0;
-
-var dropDownBg = new Image(); 
-dropDownBg.src="images/bg-dropdown.png"; 
-
-$(document).ready(function(){
-	initDropDown();
-});
-
-function initDropDown() {
-	$("#navigation-drop-down").mouseover(function(){
-      dropDownIn();
-    })
-	$("#navigation-drop-down").mouseout(function(){
-      dropDownOut();
-    })	
-}
-
-function dropDownOut() {
-	dropDownTimeOut = setTimeout('$("#navigation-drop-down").removeClass("menu");', 400);
-}
-
-function dropDownIn() {
-	clearTimeout(dropDownTimeOut);
-	$("#navigation-drop-down").addClass("menu");
-}
+// JavaScript Document
+
+var dropDownTimeOut = 0;
+
+var dropDownBg = new Image();
+dropDownBg.src="images/bg-dropdown.png";
+
+$(document).ready(function(){
+    initDropDown();
+});
+
+function initDropDown() {
+    $("#navigation-drop-down").mouseover(function(){
+        dropDownIn();
+    });
+    $("#navigation-drop-down").mouseout(function(){
+        dropDownOut();
+    });
+}
+
+function dropDownOut() {
+    dropDownTimeOut = setTimeout(function() {
+        $("#navigation-drop-down").removeClass("menu");
+    }, 400);
+}
+
+function dropDownIn() {
+    clearTimeout(dropDownTimeOut);
+    $("#navigation-drop-down").addClass("menu");
+}