launchpad-reviewers team mailing list archive

[Colin Watson <mp+407103@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:drop-native-string-adapter into launchpad:master.

Commit message:
Drop INativeString formatting adapter registration

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/407103
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:drop-native-string-adapter into launchpad:master.

diff --git a/lib/lp/app/browser/configure.zcml b/lib/lp/app/browser/configure.zcml
index 005968c..753ce04 100644
--- a/lib/lp/app/browser/configure.zcml
+++ b/lib/lp/app/browser/configure.zcml
@@ -962,15 +962,6 @@
       />
 
   <!-- TALES fmt: namespace for strings -->
-  <!-- On Python 2, registering this adapter for both INativeString and
-       ITextString covers both str (bytes) and unicode.  On Python 3, this
-       covers only str; the redundancy is harmless. -->
-  <adapter
-      for="zope.interface.common.builtins.INativeString"
-      provides="zope.traversing.interfaces.IPathAdapter"
-      factory="lp.app.browser.stringformatter.FormattersAPI"
-      name="fmt"
-      />
   <adapter
       for="zope.interface.common.builtins.ITextString"
       provides="zope.traversing.interfaces.IPathAdapter"