launchpad-reviewers team mailing list archive

[Colin Watson <mp+409527@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:drop-launchpad-fault-repr into launchpad:master.

Commit message:
Drop LaunchpadFault.__repr__ backport

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/409527
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:drop-launchpad-fault-repr into launchpad:master.

diff --git a/lib/lp/services/xmlrpc.py b/lib/lp/services/xmlrpc.py
index 85f9727..4dd0adf 100644
--- a/lib/lp/services/xmlrpc.py
+++ b/lib/lp/services/xmlrpc.py
@@ -37,14 +37,6 @@ class LaunchpadFault(xmlrpc_client.Fault):
         msg = self.msg_template % kw
         xmlrpc_client.Fault.__init__(self, self.error_code, msg)
 
-    def __repr__(self):
-        # Use the more informative version from Python >= 3.5, even if we're
-        # running on an earlier version.
-        # XXX cjwatson 2020-10-22: Remove this once we're using Python >=
-        # 3.5 everywhere.
-        return "<%s %s: %r>" % (
-            self.__class__.__name__, self.faultCode, self.faultString)
-
     def __eq__(self, other):
         if not isinstance(other, LaunchpadFault):
             return False