launchpad-reviewers team mailing list archive

[Colin Watson <mp+410744@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:clarify-db-upgrade into launchpad:master.

Commit message:
Clarify message when DB patch was already applied

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/410744

The difference between "applied <date>" and "applied just now" was a little subtle.  Add "previously" to the former case to make it slightly clearer.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:clarify-db-upgrade into launchpad:master.

diff --git a/database/schema/upgrade.py b/database/schema/upgrade.py
index 64b3f01..bab20e3 100755
--- a/database/schema/upgrade.py
+++ b/database/schema/upgrade.py
@@ -118,7 +118,7 @@ def report_patch_times(con, todays_patches):
         db_time = db_time.total_seconds()
         start_time = start_time.strftime('%Y-%m-%d')
         log.info(
-            "%d-%02d-%d applied %s in %0.1f seconds"
+            "%d-%02d-%d previously applied %s in %0.1f seconds"
             % (major, minor, patch, start_time, db_time))
 
     for major, minor, patch in todays_patches: