launchpad-reviewers team mailing list archive

[Jürgen Gmach <mp+411090@xxxxxxxxxxxxxxxxxx>]

see inline comment

Diff comments:

> diff --git a/lib/lp/services/database/enumcol.py b/lib/lp/services/database/enumcol.py
> index 3360ebe..2ce5d24 100644
> --- a/lib/lp/services/database/enumcol.py
> +++ b/lib/lp/services/database/enumcol.py
> @@ -71,6 +71,8 @@ class DBEnum(SimpleProperty):
>  
>  
>  class DBSchemaEnumCol(sqlobject.PropertyAdapter, DBEnum):
> +    """Deprecated; a SQLObject property representing a DBEnumeratedType."""

Is there a reason why you do not use `warnings.warn` to inform about the deprecation? Maybe this would mean too much "noise"? Also, could you - especially for the new joiners - explain shortly why this was deprecated? Thank you!

> +
>      def __init__(self, **kw):
>          try:
>              enum = kw.pop('enum')


-- 
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/411090
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:enumcol-is-deprecated into launchpad:master.