launchpad-reviewers team mailing list archive

[Jürgen Gmach <mp+411523@xxxxxxxxxxxxxxxxxx>]

I wonder whether we could simplify 

[memcache]
servers: (127.0.0.1:11242,1)

from configs.testrunner.launchpad-lazr.conf

into

[memcache]
server: 127.0.0.1:11242

and thus also

get rid of the regex:

    servers = [
        (host, int(weight)) for host, weight in re.findall(
            r'\((.+?),(\d+)\)', config.memcache.servers)]

pymemcache.client.base.Client only takes a single server anyway.

Also, there is no more debug argument for the init of Client, so the "1" in above configuration is not evaluated at all.
-- 
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/411523
Your team Launchpad code reviewers is requested to review the proposed merge of ~jugmac00/launchpad:replace-python-memcached-with-pymemcache into launchpad:master.