launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] ~jugmac00/launchpad:replace-python-memcached-with-pymemcache into launchpad:master

To: mp+411523@xxxxxxxxxxxxxxxxxx
From: Colin Watson <mp+411523@xxxxxxxxxxxxxxxxxx>
Date: Mon, 08 Nov 2021 19:32:12 -0000
In-reply-to: <163639946673.18965.16153253511911765275.launchpad@ackee.canonical.com>
Reply-to: mp+411523@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

I'm afraid not, because on production the value is:

  (soybean.canonical.com:11211,1),(wampee.canonical.com:11211,1),(gac.canonical.com:11211,1),(chaenomeles.canonical.com:11211,1)

See lp:lp-production-configs.

Can we use a `pymemcache.client.hash.HashClient` instead of a `pymemcache.client.base.Client`?  That's what lp:snapauth uses in the snap store, for instance.
-- 
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/411523
Your team Launchpad code reviewers is requested to review the proposed merge of ~jugmac00/launchpad:replace-python-memcached-with-pymemcache into launchpad:master.

References

[Merge] ~jugmac00/launchpad:replace-python-memcached-with-pymemcache into launchpad:master
From: Jürgen Gmach, 2021-11-08