← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] ~lgp171188/launchpad:allow-full-width-git-clone-url into launchpad:master

 

Guruprasad has proposed merging ~lgp171188/launchpad:allow-full-width-git-clone-url into launchpad:master.

Commit message:
Use full width for the git clone URLs.

LP: #1949090

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1949090 in Launchpad itself: "git clone URL is split into two lines"
  https://bugs.launchpad.net/launchpad/+bug/1949090

For more details, see:
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/412124
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~lgp171188/launchpad:allow-full-width-git-clone-url into launchpad:master.
diff --git a/lib/canonical/launchpad/icing/css/typography.scss b/lib/canonical/launchpad/icing/css/typography.scss
index 3b2e1cd..1bdd3a2 100644
--- a/lib/canonical/launchpad/icing/css/typography.scss
+++ b/lib/canonical/launchpad/icing/css/typography.scss
@@ -54,6 +54,10 @@ h1, h2, h3, h4, h5, h6 {
     max-width: $wider-page;
   }
 
+  .full-width {
+    max-width: 100%;
+  }
+
   table.wide {
     width: $wider-page;
   }
diff --git a/lib/lp/code/templates/git-macros.pt b/lib/lp/code/templates/git-macros.pt
index b7a6318..53334c9 100644
--- a/lib/lp/code/templates/git-macros.pt
+++ b/lib/lp/code/templates/git-macros.pt
@@ -17,7 +17,7 @@
 
   <dl id="clone-url">
     <dt>Get this <tal:kind replace="kind" />:</dt>
-    <dd>
+    <dd class="full-width">
       <tal:anonymous condition="repository/git_https_url">
         <tt class="command">
           git clone
@@ -71,7 +71,7 @@
       <tal:can-push tal:condition="view/user_can_push">
         <dl id="push-url">
           <dt>Update this repository:</dt>
-          <dd>
+          <dd class="full-width">
             <tt class="command">
             git push
             <span class="ssh-url" tal:content="view/git_ssh_url" />
@@ -101,7 +101,7 @@
         </tal:team>
         <dl tal:condition="context/namespace/supports_repository_forking" id="push-url">
           <dt>To fork this repository and propose fixes from there, push to this repository:</dt>
-          <dd>
+          <dd class="full-width">
             <tt class="command">
             git push
             <span class="ssh-url" tal:content="view/git_ssh_url_non_owner" />

Follow ups