launchpad-reviewers team mailing list archive

[Jürgen Gmach <mp+412161@xxxxxxxxxxxxxxxxxx>]

Jürgen Gmach has proposed merging ~jugmac00/turnip:fix-build-step into turnip:master.

Commit message:
Hardcode /usr/bin/virtualenv path

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~jugmac00/turnip/+git/turnip/+merge/412161
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~jugmac00/turnip:fix-build-step into turnip:master.

diff --git a/Makefile b/Makefile
index bb214c7..04d28a6 100644
--- a/Makefile
+++ b/Makefile
@@ -9,7 +9,7 @@ PSERVE := $(ENV)/bin/pserve
 FLAKE8 := $(ENV)/bin/flake8
 CELERY := $(ENV)/bin/celery
 PIP := $(ENV)/bin/pip
-VIRTUALENV := virtualenv
+VIRTUALENV := /usr/bin/virtualenv
 VENV_ARGS := -p python3
 
 DEPENDENCIES_URL := https://git.launchpad.net/~canonical-launchpad-branches/turnip/+git/dependencies
diff --git a/README.rst b/README.rst
index 4cf9b31..9fa4ad1 100644
--- a/README.rst
+++ b/README.rst
@@ -195,8 +195,8 @@ When adding the SSH key to LP if emails can't go out the SSH key addition will f
 One possible workaround is to use Fakeemail: https://github.com/tomwardill/fakeemail
 It is recommended that this is done in a venv (https://pypi.org/project/pipsi/):
 
-	sudo apt install pipsi
-	pipsi install fakeemail
+	sudo apt install pipx
+	pipx install fakeemail
 	~/.local/bin/fakeemail  25 8082 0.0.0.0
 	Message stored for: root@localhost