launchpad-reviewers team mailing list archive

[Colin Watson <mp+412208@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:development-error-exchange into launchpad:master.

Commit message:
Publish OOPSes to disk by default in development config

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/412208

The development config previously wrote OOPSes to rabbitmq if it was running (which it normally would be within `make run`).  But this is quite inconvenient for normal development purposes: unless you're also running something like python-oops-tools to receive OOPS reports over AMQP, they effectively disappear into the void and are difficult to find.

Although the test runner needs to preserve the previous behaviour, a better default for interactive use in `LPCONFIG=development` is to publish OOPSes to disk.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:development-error-exchange into launchpad:master.

diff --git a/configs/development/launchpad-lazr.conf b/configs/development/launchpad-lazr.conf
index c704f29..b8ba73c 100644
--- a/configs/development/launchpad-lazr.conf
+++ b/configs/development/launchpad-lazr.conf
@@ -78,6 +78,7 @@ cdimage_file_list_url: file:lib/lp/registry/tests/ubuntu-releases.testdata
 [error_reports]
 oops_prefix: X
 error_dir: /var/tmp/lperr
+error_exchange: none
 
 [bing]
 # Development and the testrunner should use the stub service by default.
diff --git a/configs/testrunner/launchpad-lazr.conf b/configs/testrunner/launchpad-lazr.conf
index 9fe2aa0..cad74b1 100644
--- a/configs/testrunner/launchpad-lazr.conf
+++ b/configs/testrunner/launchpad-lazr.conf
@@ -30,6 +30,7 @@ rw_main_standby: dbname=launchpad_ftest
 [error_reports]
 oops_prefix: T
 error_dir: /var/tmp/lperr.test
+error_exchange: oopses
 
 [gina_target.hoary]
 architectures: i386