launchpad-reviewers team mailing list archive

[Ioana Lasc <mp+412506@xxxxxxxxxxxxxxxxxx>]

Ioana Lasc has proposed merging ~ilasc/launchpad:merge-db-stable into launchpad:master.

Commit message:
Merge db-stable a349b3d306f (Add permissions on revisionstatusreport and artifact)

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~ilasc/launchpad/+git/launchpad/+merge/412506
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~ilasc/launchpad:merge-db-stable into launchpad:master.

diff --git a/database/schema/patch-2210-37-0.sql b/database/schema/patch-2210-37-0.sql
new file mode 100644
index 0000000..6a242be
--- /dev/null
+++ b/database/schema/patch-2210-37-0.sql
@@ -0,0 +1,55 @@
+-- Copyright 2021 Canonical Ltd.  This software is licensed under the
+-- GNU Affero General Public License version 3 (see the file LICENSE).
+
+SET client_min_messages=ERROR;
+
+CREATE TABLE RevisionStatusReport (
+    id serial PRIMARY KEY,
+    git_repository integer REFERENCES gitrepository NOT NULL,
+    commit_sha1 character(40) NOT NULL,
+    name text NOT NULL,
+    url text,
+    description text,
+    result integer,
+    date_created timestamp without time zone DEFAULT (CURRENT_TIMESTAMP AT TIME ZONE 'UTC') NOT NULL,
+    creator integer REFERENCES Person NOT NULL,
+    date_started timestamp without time zone,
+    date_finished timestamp without time zone
+);
+
+COMMENT ON TABLE RevisionStatusReport IS 'A status check for a code revision.';
+COMMENT ON COLUMN RevisionStatusReport.git_repository IS 'The Git repository for this report..';
+COMMENT ON COLUMN RevisionStatusReport.commit_sha1 IS 'The commit sha1 for the report.';
+COMMENT ON COLUMN RevisionStatusReport.name IS 'Name of the report.';
+COMMENT ON COLUMN RevisionStatusReport.url IS 'External URL to view result of report.';
+COMMENT ON COLUMN RevisionStatusReport.description IS 'Text description of the result.';
+COMMENT ON COLUMN RevisionStatusReport.result IS 'The result of the check job for this revision.';
+COMMENT ON COLUMN RevisionStatusReport.date_created IS 'DateTime that report was created.';
+COMMENT ON COLUMN RevisionStatusReport.creator IS 'The person that created the report.';
+COMMENT ON COLUMN RevisionStatusReport.date_started IS 'DateTime that report was started.';
+COMMENT ON COLUMN RevisionStatusReport.date_finished IS 'DateTime that report was completed.';
+
+CREATE INDEX revisionstatusreport__git_repository__commit_sha1__idx
+    ON RevisionStatusReport (git_repository, commit_sha1);
+
+CREATE INDEX revisionstatusreport__creator__idx
+    ON RevisionStatusReport (creator);
+
+CREATE TABLE RevisionStatusArtifact (
+    id serial PRIMARY KEY,
+    report integer REFERENCES RevisionStatusReport NOT NULL,
+    type integer NOT NULL,
+    library_file integer REFERENCES libraryfilealias NOT NULL
+);
+
+COMMENT ON TABLE RevisionStatusArtifact IS 'An artifact produced by a status check for a code revision.';
+COMMENT ON COLUMN RevisionStatusArtifact.report IS 'A link back to the report that the artifact was produced by.';
+COMMENT ON COLUMN RevisionStatusArtifact.type IS 'The artifact type produced by the check job.';
+COMMENT ON COLUMN RevisionStatusArtifact.library_file IS 'LibraryFileAlias storing the contents of the artifact.';
+
+CREATE INDEX revisionstatusartifact__library_file__idx
+    ON RevisionStatusArtifact (library_file);
+CREATE INDEX revisionstatusartifact__report__type__idx
+    ON RevisionStatusArtifact (report, type);
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2210, 37, 0);
diff --git a/database/schema/security.cfg b/database/schema/security.cfg
index 03c81f2..d1aa633 100644
--- a/database/schema/security.cfg
+++ b/database/schema/security.cfg
@@ -305,6 +305,8 @@ public.revision                         = SELECT, INSERT, UPDATE
 public.revisionauthor                   = SELECT, INSERT, UPDATE
 public.revisioncache                    = SELECT, INSERT, UPDATE, DELETE
 public.revisionparent                   = SELECT, INSERT
+public.revisionstatusartifact           = SELECT, INSERT, UPDATE, DELETE
+public.revisionstatusreport             = SELECT, INSERT, UPDATE, DELETE
 public.scriptactivity                   = SELECT
 public.seriessourcepackagebranch        = SELECT, INSERT, UPDATE, DELETE
 public.sharingjob                       = SELECT, INSERT, UPDATE, DELETE
@@ -484,6 +486,7 @@ public.potemplate                       = SELECT
 public.product                          = SELECT
 public.productreleasefile               = SELECT
 public.project                          = SELECT
+public.revisionstatusartifact           = SELECT
 public.snapbuild                        = SELECT
 public.snapfile                         = SELECT
 public.sourcepackagerecipebuild         = SELECT
@@ -2412,6 +2415,7 @@ public.questionreopening                = SELECT, UPDATE
 public.questionsubscription             = SELECT, UPDATE, DELETE
 public.revision                         = SELECT, UPDATE
 public.revisionauthor                   = SELECT, UPDATE
+public.revisionstatusreport             = SELECT, UPDATE
 public.seriessourcepackagebranch        = SELECT, UPDATE
 public.sharingjob                       = SELECT, INSERT, UPDATE
 public.signedcodeofconduct              = SELECT, UPDATE