launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #27806
Re: [Merge] ~jugmac00/launchpad:prevent-email-disclosure into launchpad:master
This looks good as far as it goes.
https://git.launchpad.net/launchpad/tree/lib/lp/soyuz/mail/binarypackagebuild.py#n166 isn't a problem: an SPR's creator is a single person.
The importer in https://git.launchpad.net/launchpad/tree/lib/lp/translations/scripts/po_import.py#n145 sometimes ends up being ~rosetta-admins, which is a large team, so let's add a loop there.
https://git.launchpad.net/launchpad/tree/lib/lp/translations/scripts/translations_to_branch.py#n297 is marginal, but I'd be inclined to leave it alone, at least for now; I think the case where a team explicitly owns something is a bit different from the mirror-admins and rosetta-admins cases where the ownership is rather more, um, ambient.
--
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/412672
Your team Launchpad code reviewers is requested to review the proposed merge of ~jugmac00/launchpad:prevent-email-disclosure into launchpad:master.
References