launchpad-reviewers team mailing list archive

[Colin Watson <mp+412714@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:distroseries-export-not-automatic into launchpad:master.

Commit message:
Export DistroSeries.{backports,proposed}_not_automatic

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/412714

It's otherwise rather difficult to change these settings, requiring SQL.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:distroseries-export-not-automatic into launchpad:master.

diff --git a/lib/lp/registry/interfaces/distroseries.py b/lib/lp/registry/interfaces/distroseries.py
index da0e19e..548d598 100644
--- a/lib/lp/registry/interfaces/distroseries.py
+++ b/lib/lp/registry/interfaces/distroseries.py
@@ -365,22 +365,22 @@ class IDistroSeriesPublic(
     language_packs = Attribute(
         "All language packs associated with this distribution series.")
 
-    backports_not_automatic = Bool(
+    backports_not_automatic = exported(Bool(
         title=_("Don't upgrade to backports automatically"), required=True,
         description=_("""
             Set NotAutomatic: yes and ButAutomaticUpgrades: yes in Release
             files generated for the backports pocket. This tells apt to
             automatically upgrade within backports, but not into it.
-            """))
+            """)))
 
-    proposed_not_automatic = Bool(
+    proposed_not_automatic = exported(Bool(
         title=_("Don't upgrade to proposed updates automatically"),
         required=True,
         description=_("""
             Set NotAutomatic: yes and ButAutomaticUpgrades: yes in Release
             files generated for the proposed pocket. This tells apt to
             automatically upgrade within proposed, but not into it.
-            """))
+            """)))
 
     include_long_descriptions = exported(
         Bool(
diff --git a/lib/lp/registry/stories/webservice/xx-distroseries.txt b/lib/lp/registry/stories/webservice/xx-distroseries.txt
index 520e3bb..236b664 100644
--- a/lib/lp/registry/stories/webservice/xx-distroseries.txt
+++ b/lib/lp/registry/stories/webservice/xx-distroseries.txt
@@ -63,6 +63,7 @@ For distroseries we publish a subset of its attributes.
     advertise_by_hash: False
     all_milestones_collection_link: 'http://.../ubuntu/hoary/all_milestones'
     architectures_collection_link: 'http://.../ubuntu/hoary/architectures'
+    backports_not_automatic: False
     bug_reported_acknowledgement: None
     bug_reporting_guidelines: None
     changeslist: 'hoary-changes@xxxxxxxxxx'
@@ -84,6 +85,7 @@ For distroseries we publish a subset of its attributes.
     official_bug_tags: []
     owner_link: 'http://.../~ubuntu-team'
     parent_series_link: 'http://.../ubuntu/warty'
+    proposed_not_automatic: False
     publish_by_hash: False
     registrant_link: 'http://.../~mark'
     resource_type_link: ...