launchpad-reviewers team mailing list archive

[Colin Watson <mp+413165@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:quieten-memcache-client-logging into launchpad:master.

Commit message:
Remove some excessive logging from TimelineRecordingClient

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/413165

This doesn't seem very useful now that the `MemcacheClient` superclass has its own logging in error cases, and it resulted in spammy messages when setting up `MemcachedLayer` due to calling `logging.warning` directly rather than using the `logger` argument.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:quieten-memcache-client-logging into launchpad:master.

diff --git a/lib/lp/services/memcache/timeline.py b/lib/lp/services/memcache/timeline.py
index 52841e6..33ae1bf 100644
--- a/lib/lp/services/memcache/timeline.py
+++ b/lib/lp/services/memcache/timeline.py
@@ -7,8 +7,6 @@ __all__ = [
     'TimelineRecordingClient',
     ]
 
-import logging
-
 from lazr.restful.utils import get_current_browser_request
 
 from lp.services import features
@@ -45,11 +43,6 @@ class TimelineRecordingClient(MemcacheClient):
             return None
         action = self.__get_timeline_action("set", key)
         try:
-            success = super().set(key, value, expire=expire, logger=logger)
-            if success:
-                logging.debug("Memcache set succeeded for %s", key)
-            else:
-                logging.warning("Memcache set failed for %s", key)
-            return success
+            return super().set(key, value, expire=expire, logger=logger)
         finally:
             action.finish()