launchpad-reviewers team mailing list archive

[Colin Watson <mp+413402@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:fix-project-download-queries into launchpad:master.

Commit message:
Fix ILibraryFileAliasSet.preloadLastDownloaded declaration

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/413402

It had an extra `self` parameter.  `FakeLibrarian` also needs a stub definition of this method.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:fix-project-download-queries into launchpad:master.

diff --git a/lib/lp/services/librarian/interfaces/__init__.py b/lib/lp/services/librarian/interfaces/__init__.py
index 73b390b..bf4055f 100644
--- a/lib/lp/services/librarian/interfaces/__init__.py
+++ b/lib/lp/services/librarian/interfaces/__init__.py
@@ -175,7 +175,7 @@ class ILibraryFileAliasSet(Interface):
         given sha256.
         """
 
-    def preloadLastDownloaded(self, lfas):
+    def preloadLastDownloaded(lfas):
         """Preload last_downloaded for a collection of `LibraryFileAlias`es."""
 
 
diff --git a/lib/lp/services/librarianserver/testing/fake.py b/lib/lp/services/librarianserver/testing/fake.py
index ed17038..0dfc37a 100644
--- a/lib/lp/services/librarianserver/testing/fake.py
+++ b/lib/lp/services/librarianserver/testing/fake.py
@@ -181,6 +181,9 @@ class FakeLibrarian(Fixture):
 
         return None
 
+    def preloadLastDownloaded(self, lfas):
+        """See `ILibraryFileAliasSet`."""
+
     def beforeCompletion(self, txn):
         """See `ISynchronizer`."""