launchpad-reviewers team mailing list archive

[Jürgen Gmach <mp+413627@xxxxxxxxxxxxxxxxxx>]

LGTM - In the long term we could implement a `-c` option to pass in a configuration file, which would not make us to use `os.cwdir` which probably could cause problems once we'll run tests in parallel.

This took me a bit to reproduce, as I experienced not such a problem in my local env.

I have a local `.launchpad.yaml` file for testing, and it was "not" changed.

Turns out, this file was open in a VS Code tab, and while the file was overwritten (checked via `less`), the tab content did not change and as soon I continued working in VS Code the previous state was restored, so I did not experience the test isolation problem.

While trying to reproduce the problem, I also ran tox in parallel mode to provoke the test isolation error, I noticed we have another problem which I reported at https://bugs.launchpad.net/lpcraft/+bug/1956430
-- 
https://code.launchpad.net/~cjwatson/lpcraft/+git/lpcraft/+merge/413627
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/lpcraft:plugin-test-isolation into lpcraft:main.