launchpad-reviewers team mailing list archive

[Jürgen Gmach <mp+413804@xxxxxxxxxxxxxxxxxx>]

Jürgen Gmach has proposed merging ~jugmac00/lpcraft:add-comment-about-pinning-tox-version into lpcraft:main.

Commit message:
Add todo comment about pinning tox

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~jugmac00/lpcraft/+git/lpcraft/+merge/413804
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~jugmac00/lpcraft:add-comment-about-pinning-tox-version into lpcraft:main.

diff --git a/lpcraft/plugins/plugins.py b/lpcraft/plugins/plugins.py
index 0438598..1b84235 100644
--- a/lpcraft/plugins/plugins.py
+++ b/lpcraft/plugins/plugins.py
@@ -28,6 +28,8 @@ class ToxPlugin:
 
     @hookimpl  # type: ignore
     def lpcraft_execute_run(self) -> str:
+        # XXX jugmac00 2022-01-07: we should consider using a requirements.txt
+        # as this allows updateing via `pip-tools`
         return "python3 -m pip install tox==3.24.5; tox"
 
     @hookimpl  # type: ignore