launchpad-reviewers team mailing list archive

[Guruprasad <mp+413934@xxxxxxxxxxxxxxxxxx>]

Guruprasad has proposed merging ~lgp171188/launchpad:add-locked-column-to-bug-table into launchpad:db-devel.

Commit message:
Add 'locked' field to Bug
    
This will be used to store the values of an enum containing the possible values.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/413934
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~lgp171188/launchpad:add-locked-column-to-bug-table into launchpad:db-devel.

diff --git a/database/schema/patch-2210-38-0.sql b/database/schema/patch-2210-38-0.sql
new file mode 100644
index 0000000..fca2fec
--- /dev/null
+++ b/database/schema/patch-2210-38-0.sql
@@ -0,0 +1,18 @@
+-- Copyright 2022 Canonical Ltd.  This software is licensed under the
+-- GNU Affero General Public License version 3 (see the file LICENSE).
+
+SET client_min_messages=ERROR;
+
+ALTER TABLE Bug
+    ADD COLUMN locked INTEGER;
+
+-- ALTER COLUMN ... SET DEFAULT doesn't trigger a table rewrite,
+-- while ADD COLUMN ... DEFAULT xx does. In pg <11 this operation is slow.
+-- That's why we first create, and then we set the default value.
+-- Data backfilling will be done in a hot patch instead of a fast downtime.
+
+ALTER TABLE Bug ALTER COLUMN locked SET DEFAULT 1;
+
+COMMENT ON COLUMN Bug.locked IS 'The current lock status of this bug.';
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2210, 38, 0);