launchpad-reviewers team mailing list archive

[Colin Watson <mp+414195@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/turnip:bump-more-timeouts into turnip:master.

Commit message:
Bump some more test timeouts to 10 seconds

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/turnip/+git/turnip/+merge/414195
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/turnip:bump-more-timeouts into turnip:master.

diff --git a/turnip/api/tests/test_api.py b/turnip/api/tests/test_api.py
index 9737eb0..ca47021 100644
--- a/turnip/api/tests/test_api.py
+++ b/turnip/api/tests/test_api.py
@@ -1030,7 +1030,8 @@ class AsyncRepoCreationAPI(TestCase, ApiRepoStoreMixin):
         for i in range(reactor_iterations):
             default_reactor.iterate()
 
-    def assertRepositoryCreatedAsynchronously(self, repo_path, timeout_secs=5):
+    def assertRepositoryCreatedAsynchronously(self, repo_path,
+                                              timeout_secs=10):
         """Waits up to `timeout_secs` for a repository to be available."""
         timeout = timedelta(seconds=timeout_secs)
         start = datetime.now()
@@ -1049,7 +1050,7 @@ class AsyncRepoCreationAPI(TestCase, ApiRepoStoreMixin):
             "Repository %s was not created after %s secs"
             % (repo_path, timeout_secs))
 
-    def assertAnyMockCalledAsync(self, mocks, timeout_secs=5):
+    def assertAnyMockCalledAsync(self, mocks, timeout_secs=10):
         """Asserts that any of the mocks in *args will be called in the
         next timeout_secs seconds.
         """
diff --git a/turnip/pack/tests/test_git.py b/turnip/pack/tests/test_git.py
index f5c04c0..7d8fba7 100644
--- a/turnip/pack/tests/test_git.py
+++ b/turnip/pack/tests/test_git.py
@@ -176,7 +176,7 @@ class TestPackFrontendServerProtocol(TestCase):
 class TestPackBackendProtocol(TestCase):
     """Test the Git pack backend protocol."""
 
-    run_tests_with = AsynchronousDeferredRunTest.make_factory(timeout=5)
+    run_tests_with = AsynchronousDeferredRunTest.make_factory(timeout=10)
 
     def setUp(self):
         super().setUp()
@@ -369,7 +369,7 @@ class DummyPackBackendFactory(git.PackBackendFactory):
 class TestPackVirtServerProtocol(TestCase):
     """Test the Git pack virt protocol."""
 
-    run_tests_with = AsynchronousDeferredRunTest.make_factory(timeout=5)
+    run_tests_with = AsynchronousDeferredRunTest.make_factory(timeout=10)
 
     def assertKilledWith(self, message):
         self.assertFalse(self.transport.connected)
diff --git a/turnip/pack/tests/test_hookrpc.py b/turnip/pack/tests/test_hookrpc.py
index 585148f..4270764 100644
--- a/turnip/pack/tests/test_hookrpc.py
+++ b/turnip/pack/tests/test_hookrpc.py
@@ -193,7 +193,7 @@ class TestRPCServerProtocol(TestCase):
 class TestHookRPCHandler(TestCase):
     """Test the hook RPC handler."""
 
-    run_tests_with = AsynchronousDeferredRunTest.make_factory(timeout=5)
+    run_tests_with = AsynchronousDeferredRunTest.make_factory(timeout=10)
 
     def setUp(self):
         super().setUp()
diff --git a/turnip/pack/tests/test_hooks.py b/turnip/pack/tests/test_hooks.py
index 481f0e1..39215df 100644
--- a/turnip/pack/tests/test_hooks.py
+++ b/turnip/pack/tests/test_hooks.py
@@ -166,7 +166,7 @@ class TestNetstringRecv(TestCase):
 
 
 class HookTestMixin(object):
-    run_tests_with = AsynchronousDeferredRunTest.make_factory(timeout=5)
+    run_tests_with = AsynchronousDeferredRunTest.make_factory(timeout=10)
 
     old_sha1 = b'a' * 40
     new_sha1 = b'b' * 40
diff --git a/turnip/pack/tests/test_http.py b/turnip/pack/tests/test_http.py
index 66e4a84..b1158d1 100644
--- a/turnip/pack/tests/test_http.py
+++ b/turnip/pack/tests/test_http.py
@@ -186,7 +186,7 @@ class ErrorTestMixin(object):
 
 class TestSmartHTTPRefsResource(ErrorTestMixin, TestCase):
 
-    run_tests_with = AsynchronousDeferredRunTest.make_factory(timeout=5)
+    run_tests_with = AsynchronousDeferredRunTest.make_factory(timeout=10)
 
     request_method = 'GET'
 
@@ -280,7 +280,7 @@ class TestSmartHTTPRefsResource(ErrorTestMixin, TestCase):
 
 class TestSmartHTTPCommandResource(ErrorTestMixin, TestCase):
 
-    run_tests_with = AsynchronousDeferredRunTest.make_factory(timeout=5)
+    run_tests_with = AsynchronousDeferredRunTest.make_factory(timeout=10)
 
     def setUp(self):
         super().setUp()
@@ -379,7 +379,7 @@ class TestHTTPAuthLoginResource(TestCase):
 
 class TestHTTPAuthRootResource(TestCase):
 
-    run_tests_with = AsynchronousDeferredRunTest.make_factory(timeout=5)
+    run_tests_with = AsynchronousDeferredRunTest.make_factory(timeout=10)
 
     def setUp(self):
         super().setUp()