launchpad-reviewers team mailing list archive

[Colin Watson <mp+414668@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:editpgpkeys-gpg-v1-warning into launchpad:master.

Commit message:
Add key type warning to Person:+editpgpkeys

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1827369 in Launchpad itself: "Launchpad cannot handle ECC or Ed25519 OpenPGP keys"
  https://bugs.launchpad.net/launchpad/+bug/1827369

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/414668

Launchpad can currently only handle OpenPGP keys that are compatible with GnuPG v1.  Tell users about this so that fewer people are confused about why their keys aren't being imported successfully.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:editpgpkeys-gpg-v1-warning into launchpad:master.

diff --git a/lib/lp/registry/templates/person-editpgpkeys.pt b/lib/lp/registry/templates/person-editpgpkeys.pt
index 169c5f0..42f2c13 100644
--- a/lib/lp/registry/templates/person-editpgpkeys.pt
+++ b/lib/lp/registry/templates/person-editpgpkeys.pt
@@ -163,6 +163,13 @@
         fingerprint</a>)
       </p>
 
+      <p>
+        At present, only keys compatible with GnuPG v1 are supported.
+        Elliptic curve keys are
+        <a href="https://bugs.launchpad.net/launchpad/+bug/1827369";>not
+        yet supported</a>.
+      </p>
+
           <table class="form" id="launchpad-form-widgets">
             <tbody>
               <tr>