launchpad-reviewers team mailing list archive

[Colin Watson <mp+414953@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:fix-tighten-bug-permissions into launchpad:master.

Commit message:
Fix xx-bug-branch-links.txt for bug permission changes

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/414953
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:fix-tighten-bug-permissions into launchpad:master.

diff --git a/lib/lp/code/stories/branches/xx-bug-branch-links.txt b/lib/lp/code/stories/branches/xx-bug-branch-links.txt
index 3661261..b9422dc 100644
--- a/lib/lp/code/stories/branches/xx-bug-branch-links.txt
+++ b/lib/lp/code/stories/branches/xx-bug-branch-links.txt
@@ -99,15 +99,18 @@ Sample person can see it...
 From the bug page
 =================
 
-The action link on the bug page is "Link a related branch".  Again this
-links to a page restricted with the launchpad.AnyPerson permission.
+The action link on the bug page is "Link a related branch".  This links to a
+page restricted with the launchpad.Edit permission.
 
-    >>> anon_browser.open(
-    ...     'http://launchpad.test/bugs/11')
-    >>> anon_browser.getLink('Link a related branch').click()
+    >>> anon_browser.open('http://launchpad.test/bugs/11')
+    >>> anon_browser.getLink('Link a related branch')
     Traceback (most recent call last):
     ...
-    zope.security.interfaces.Unauthorized: (...launchpad.AnyPerson')
+    zope.testbrowser.browser.LinkNotFoundError
+    >>> anon_browser.open('http://launchpad.test/jokosher/+bug/11/+addbranch')
+    Traceback (most recent call last):
+    ...
+    zope.security.interfaces.Unauthorized: (...launchpad.Edit')
 
     >>> browser.open(
     ...     'http://launchpad.test/bugs/11')